[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Francesco Lavra]

On Sun, 2009-08-02 at 10:56 +0200, Diego Biurrun wrote:
> On Sun, Aug 02, 2009 at 10:18:02AM +0200, Francesco Lavra wrote:
> > 
> > --- libmpcodecs/dec_teletext.h	(revision 0)
> > +++ libmpcodecs/dec_teletext.h	(revision 0)
> > @@ -0,0 +1,114 @@
> > +#ifndef MPLAYER_DEC_TELETEXT_H
> > +#define MPLAYER_DEC_TELETEXT_H
> 
> This is missing the standard license header.
Added in the attached patch
> 
> > --- command.c	(revision 29464)
> > +++ command.c	(working copy)
> > @@ -57,6 +57,9 @@
> >  #ifdef CONFIG_GUI
> >  #include "gui/interface.h"
> >  #endif
> > +#ifdef CONFIG_TV_TELETEXT
> > +#include "libmpcodecs/dec_teletext.h"
> > +#endif
> 
> Is the #ifdef necessary?
It is not really necessary, I just followed the coding style present in
that file (see the 30 or so lines above my addition)
> 
> I think this patch would be smaller if you moved stuff around with 'svn
> cp' before creating the diff.
I don't think so, dec_teletext.h takes about 110 out of 350 lines of
code from tv.h

Francesco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dec_teletext.patch
Type: text/x-patch
Size: 76471 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090802/3a34eb28/attachment.bin>