[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Diego Biurrun]

On Sun, Aug 02, 2009 at 10:18:02AM +0200, Francesco Lavra wrote:
> 
> --- libmpcodecs/dec_teletext.h	(revision 0)
> +++ libmpcodecs/dec_teletext.h	(revision 0)
> @@ -0,0 +1,114 @@
> +#ifndef MPLAYER_DEC_TELETEXT_H
> +#define MPLAYER_DEC_TELETEXT_H

This is missing the standard license header.

> --- command.c	(revision 29464)
> +++ command.c	(working copy)
> @@ -57,6 +57,9 @@
>  #ifdef CONFIG_GUI
>  #include "gui/interface.h"
>  #endif
> +#ifdef CONFIG_TV_TELETEXT
> +#include "libmpcodecs/dec_teletext.h"
> +#endif

Is the #ifdef necessary?

I think this patch would be smaller if you moved stuff around with 'svn
cp' before creating the diff.

Diego