[MPlayer-dev-eng] [PATCH] Support for video capture from National Instruments cards

[Sebastien Raveau]

On Thu, Apr 23, 2009 at 8:28 PM, Diego Biurrun <diego at biurrun.de> wrote:
>> +#define _IMG_BASE 0x3FF60000
>
> Identifiers starting with an underscore and uppercase letters are
> reserved for the system.

Wanted to stay consistent with the National Instruments API, but I'll
change that, no problem.


>> +/* private data's */
>
> What is "data's" supposed to mean? :)

I don't know :-D
Just used the skeleton from tvi_dummy.c and/or tvi_bsdbt848.c
But ok I'll remove that :-)


>> +typedef struct {
>> +} priv_t;
>
> _t is POSIX-reserved namespace.  Yes, we have lots of these, but don't
> add more.

Ok ok :-)


>> +    switch(cmd)
>> +    {
>
> switch (cmd) {

Same, this is code from tvi_dummy.c and/or tvi_bsdbt848.c files, but
ok I'll change it too.


Best regards,

-- 
Sebastien Raveau