[MPlayer-dev-eng] [PATCH] Support for video capture from National Instruments cards

[Diego Biurrun]

On Thu, Apr 23, 2009 at 01:49:32PM +0200, Sebastien Raveau wrote:
> 
> --- mplayer-export-2009-04-23/stream/tvi_ni.c	1970-01-01 01:00:00.000000000 +0100
> +++ mplayer/stream/tvi_ni.c	2009-04-23 10:31:52.000000000 +0200
> @@ -0,0 +1,235 @@
> +
> +#define _IMG_BASE 0x3FF60000

Identifiers starting with an underscore and uppercase letters are
reserved for the system.

> +/* private data's */

What is "data's" supposed to mean? :)

> +typedef struct {
> +} priv_t;

_t is POSIX-reserved namespace.  Yes, we have lots of these, but don't
add more.

> +    switch(cmd)
> +    {

switch (cmd) {

Diego