[MPlayer-dev-eng] [PATCH] Support for video capture from National Instruments cards

[Diego Biurrun]

On Fri, Apr 24, 2009 at 11:27:36AM +0200, Sebastien Raveau wrote:
> On Thu, Apr 23, 2009 at 8:28 PM, Diego Biurrun <diego at biurrun.de> wrote:
> >> +#define _IMG_BASE 0x3FF60000
> >
> > Identifiers starting with an underscore and uppercase letters are
> > reserved for the system.
> 
> Wanted to stay consistent with the National Instruments API, but I'll
> change that, no problem.

Everybody and their brother does this wrong..

Probably they look at libc headers and mindlessly copy from there..

> >> +    switch(cmd)
> >> +    {
> >
> > switch (cmd) {
> 
> Same, this is code from tvi_dummy.c and/or tvi_bsdbt848.c files, but
> ok I'll change it too.

New files should be K&R style.

Diego