[MPlayer-dev-eng] [PATCH]Reduce version.h dependencies
Carl Eugen Hoyos
cehoyos at ag.or.at
Sat Apr 4 21:04:38 CEST 2009
Uoti Urpala <uoti.urpala <at> pp1.inet.fi> writes:
> > +char *mplayer_version = VERSION;
>
> You're first creating a string object and then a pointer object which
> records the address of the string object, and making code elsewhere
> start from the address of the pointer object. This indirection is
> completely pointless. Make it "const char mplayer_version[]".
Thank you for explaining.
Carl Eugen
More information about the MPlayer-dev-eng
mailing list