[MPlayer-dev-eng] [PATCH]Reduce version.h dependencies

[Uoti Urpala]

On Sat, 2009-04-04 at 16:52 +0000, Carl Eugen Hoyos wrote:
> There are two unrelated problems, first is that version.sh is completely broken
> for a long time and touches version.h after every svn up (no matter if something
> was updated or not). Patch pending.

Better check the complete contents of the file like configure does for
config.h.

> win32/gui.c)). I thought it would make more sense to reduce this number using a
> global variable VERSION and then change Makefile to know mpcommon.o depends on
> version.h.

> +char *mplayer_version = VERSION;

You're first creating a string object and then a pointer object which
records the address of the string object, and making code elsewhere
start from the address of the pointer object. This indirection is
completely pointless. Make it "const char mplayer_version[]".