[MPlayer-dev-eng] [PATCH]Reduce version.h dependencies

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Apr 4 19:09:52 CEST 2009


On Sat, Apr 04, 2009 at 07:01:25PM +0200, Reimar Döffinger wrote:
> On Sat, Apr 04, 2009 at 04:52:26PM +0000, Carl Eugen Hoyos wrote:
> > There are two unrelated problems, first is that version.sh is completely broken
> > for a long time and touches version.h after every svn up (no matter if something
> > was updated or not). Patch pending.
> 
> Well, that's maybe 3 files, not a big deal IMO.
> 
> > The
> > simple solution would be to teach Makefile exactly the dependencies version.h is
> > needed for (the files in this patch plus muxer_avi.c and something like
> > win32/gui.c)). I thought it would make more sense to reduce this number using a
> > global variable VERSION and then change Makefile to know mpcommon.o depends on
> > version.h.
> 
> Except for compiling with DEPS=no, that should be autodetected via the
> generated .d files I think...

I see, generating the .d files might fail. Well, this would be enough
to fix that and at least only the .d files will be regenerated then.
Is there a way to make "make" ignore the creation data and instead only
have it depend only on the existence of a file?
I guess that is a bit of a hack, since it assumes that those .h files
will always include the same other files but still...
Index: Makefile
===================================================================
--- Makefile    (revision 29139)
+++ Makefile    (working copy)
@@ -862,7 +862,7 @@
 ###### dependency declarations / specific CFLAGS ######
 
 # Make sure all generated header files are created.
-$(DEPS) $(MENCODER_DEPS) $(MPLAYER_DEPS): codecs.conf.h help_mp.h version.h
+$(DEPS): codecs.conf.h help_mp.h version.h
 
 libdvdcss/%: CFLAGS += -D__USE_UNIX98 -D_GNU_SOURCE -DVERSION=\"1.2.10\" $(CFLAGS_LIBDVDCSS)
 libdvdnav/%: CFLAGS += -D__USE_UNIX98 -D_GNU_SOURCE -DHAVE_CONFIG_H -DVERSION=\"MPlayer-custom\"
> 



More information about the MPlayer-dev-eng mailing list