[MPlayer-dev-eng] [PATCH]Reduce version.h dependencies

[Diego Biurrun]

On Sat, Apr 04, 2009 at 06:31:15PM +0200, Carl Eugen Hoyos wrote:
> 
> I'm still fighting rebuild duration (and I wonder which measure against 
> spurious rebuilds ever worked: It is broken since at least several 
> hundred revisions).
> Attached patch is not sufficient, but moves us in the right direction, 
> imo.
> 
> Please comment, Carl Eugen

Even though we have addressed the spurious rebuild problems, I think
this patch is probably an improvement.

> --- vobsub.c	(revision 29137)
> +++ vobsub.c	(working copy)
> @@ -1255,6 +1254,8 @@
>  
> +extern char *mplayer_version;

Maybe this should be added to mpcommon.h instead of every C file.

> --- stream/network.c	(revision 29137)
> +++ stream/network.c	(working copy)
> @@ -203,8 +202,10 @@
>  	else
> -	    http_set_field( http_hdr, "User-Agent: MPlayer/"VERSION);
> -
> +        {
> +            snprintf(str, 256, "User-Agent: MPlayer/%s", mplayer_version);
> +	    http_set_field( http_hdr, str);

Get rid of the tab while you're at it.

Diego