[MPlayer-dev-eng] MNG support for MPlayer

[Reimar Döffinger]

On Thu, Sep 25, 2008 at 01:22:20PM +0200, Stefan Schuermans wrote:
> Stefan Schuermans wrote:
> > Diego Biurrun wrote:
> >> On Thu, Sep 18, 2008 at 10:47:00PM +0200, Stefan Schuermans wrote:
> >>> --- configure    (revision 27638)
> >>> +++ configure    (working copy)
> >>> @@ -4683,6 +4687,33 @@
> >>>  
> >>> +echocheck "MNG support"
>  >>> [...]
> >>
> >> I wonder why tmp_run is necessary?  And yes, I know that the libpng test
> >> does it as well...
> > 
> > If I've understood this correctly, cc_check tries to compile and link 
> > the C source and tmp_run tries to run the result. I think it is 
> > neccessary to run the code to detect if linking against libmng works. 
> > I've seen it at least once (with some broken libmng installation) that 
> > compiling and linking worked, but the binary did not run. I'm not sure 
> > any more if it crashed or did not load due to not finding libmng.so.
> > 
> >> Your code is laboriously commented.  Possibly some of it could be
> >> doxygenized.
> > 
> > I did that and hope the style of the the doxygen comments is okay.
> 
> Any comments regarding the patch I sent last week? If there are no 
> further suggestions for improvement please apply it.

Well, there are some minor things I do not really like (sometimes excessive
comments, that would have the pointer to the whole demuxer in the priv
struct when the stream would be enough, and I also wonder what happens
to the alpha channel, does MNG not support it, or just libmng or?),
but I leave that to you if you have the time and motivation to look into that.
What IMO is not acceptable though is the configure check: AFAICT it
tries to execute the binary, which means it will always fail when
cross-compiling. I think there is no real need for that.

Greetings,
Reimar Döffinger