[MPlayer-dev-eng] MNG support for MPlayer

[Stefan Schuermans]

Stefan Schuermans wrote:
> Diego Biurrun wrote:
>> On Thu, Sep 18, 2008 at 10:47:00PM +0200, Stefan Schuermans wrote:
>>> --- configure    (revision 27638)
>>> +++ configure    (working copy)
>>> @@ -4683,6 +4687,33 @@
>>>  
>>> +echocheck "MNG support"
 >>> [...]
>>
>> I wonder why tmp_run is necessary?  And yes, I know that the libpng test
>> does it as well...
> 
> If I've understood this correctly, cc_check tries to compile and link 
> the C source and tmp_run tries to run the result. I think it is 
> neccessary to run the code to detect if linking against libmng works. 
> I've seen it at least once (with some broken libmng installation) that 
> compiling and linking worked, but the binary did not run. I'm not sure 
> any more if it crashed or did not load due to not finding libmng.so.
> 
>> Your code is laboriously commented.  Possibly some of it could be
>> doxygenized.
> 
> I did that and hope the style of the the doxygen comments is okay.

Any comments regarding the patch I sent last week? If there are no 
further suggestions for improvement please apply it.

Greetings,
Stefan