[MPlayer-dev-eng] MNG support for MPlayer

[Stefan Schuermans]

Diego Biurrun wrote:
> On Thu, Sep 18, 2008 at 10:47:00PM +0200, Stefan Schuermans wrote:
>> --- configure	(revision 27638)
>> +++ configure	(working copy)
>> @@ -4683,6 +4687,33 @@
>>  
>> +echocheck "MNG support"
>> +if test "$_mng" = auto ; then
>> +  _mng=no
>> +  cat > $TMPC << EOF
>> +#include <libmng.h>
>> +int main(void) {
>> +  const char * p_ver = mng_version_text() ?: "";
>> +  printf("libmng: %s\n", p_ver);
>> +  return p_ver[0] == 0;
>> +}
>> +EOF
>> +  if cc_check -lmng -lz $_ld_lm ; then
>> +    if tmp_run ; then
>> +      _mng=yes
>> +    else
>> +      _res_comment="no library version"
>> +    fi
>> +  fi
>> +fi
> 
> I wonder why tmp_run is necessary?  And yes, I know that the libpng test
> does it as well...

If I've understood this correctly, cc_check tries to compile and link 
the C source and tmp_run tries to run the result. I think it is 
neccessary to run the code to detect if linking against libmng works. 
I've seen it at least once (with some broken libmng installation) that 
compiling and linking worked, but the binary did not run. I'm not sure 
any more if it crashed or did not load due to not finding libmng.so.

> Your code is laboriously commented.  Possibly some of it could be
> doxygenized.

I did that and hope the style of the the doxygen comments is okay.

Greetings,
Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: MPlayer-svn20080919-mng.diff
Type: text/x-patch
Size: 25360 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080919/77d19cc6/attachment.bin>