[MPlayer-dev-eng] [PATCH] Xv Adaptor Selection

[Ivan Kalvachev]

On Tue, May 13, 2008 at 8:53 PM, Benjamin Zores <ben at geexbox.org> wrote:
> Benjamin Zores a écrit :
>
>
> > Hi,
>  >
>  > Attached patch adds a new suboption to -vo xv, that can be used to
>  > choose which Xv adaptor
>  > to use to render a video. It is normally possible to do the same
>  > through -vo xv:port=%d
>  > but you need to know which port has been mapped to your adaptor and
>  > it's a bit more complicated
>  > (at least, less user friendly).
>  >
>  > It is particularly useful not to choose Adaptor #0 (default) as, for
>  > weird reason, most of
>  > nowadays Xorg drivers tend to have the texture blitting engine as #0
>  > and the genuine overlay engine as #1
>  > (and overlay engine supports much more features and works far better,
>  > for example, using i945 Intel cards
>  > and above, the default renderer causes nasty tearing effects).
>  >
>  > If it's OK by everyone, I'll commit such a patch within the week
>  > (with updated doc and the necessary changes for XvMC too).
>
>  Applied earlier than expected to vo_xv and vo_xvmc.
>  Documentation updated accordingly.

Are you joining the show of rule breakers?

First, you haven't read the manual,
we have "-adapter" option that does the same (for directx). Your patch
doesn't honor it.

Second, I am maintainer of xvmc, technically you need my permission.

Third, You didn't even waited for a day.

Fourth. your patch didn't contain the changes in vo_xvmc.c . I
couldn't have approved it even if you waited enough for my review.


I won't request to revert the code, only because it implements useful
feature that others have objected to be implemented.
I'd however expect that you update your code to honor the global
"-adapter" asap.