[MPlayer-dev-eng] [PATCH] Xv Adaptor Selection

[Uoti Urpala]

On Wed, 2008-05-14 at 00:40 +0300, Ivan Kalvachev wrote:
> On Tue, May 13, 2008 at 8:53 PM, Benjamin Zores <ben at geexbox.org> wrote:
> > Benjamin Zores a écrit :
> >  > Attached patch adds a new suboption to -vo xv, that can be used to
> >  > choose which Xv adaptor
> >  > to use to render a video. It is normally possible to do the same

> First, you haven't read the manual,
> we have "-adapter" option that does the same (for directx). Your patch
> doesn't honor it.

The -adapter option is documented to select a graphics card, not XV
adaptor from options typically using the same card (it's not even quite
the same term, "adapter" vs "adaptor"). If you want to change something
I think it would be better to change -adapter from a global option to a
directx suboption (unless you want to generalize it to multiple VOs
somehow, but I doubt there would be any generalization applicable to
multiple VOs that would map to adaptor in XV case).