[MPlayer-dev-eng] [PATCH] add optional device with dvd://

[elupus]

Mathieu SCHROETER <mathieu.schroeter <at> gamesover.ch> writes:

> 
> Hello,
> 
> this patch will add an optional argument for stream_dvd to handle
> a dvd_device with the MRL..  like cdda, vcd, etc, ...
> Very useful when MPlayer is used with "-slave -idle" modes..
> 
> dvd://[title|[start_title]-end_title][/device]
> 
> An optional device can be already used with dvdnav://, but that is
> not specified in the manpage. This patch will fix the manpage too..
> 
> I'm not sure if that is the best way for a thing.. when dvd_close()
> is called, there is no way in order to read the optional argument.
> Then I've added a global variable with the current device used.
> And if the argument is NULL, dvd_device is used as before..
> 
> Regards,
> 
> Attachment (stream_dvd-optional_device.patch): text/x-patch, 3697 bytes

This may be abit late, but i find this counter intuative. 

Something like would have made more sence imho.
dvd://[device/][title|[start_title]-end_title]

Can then also have been extended to:
dvd://[device/][title|[start_title]-end_title]/[part|[start_part]-end_part]

Then again, you'd have to url encode the device name, to be able to specify 
any device file (which btw is how we handle combined urls for rars/zips in 
xbmc), so maybe not so good idea afterall as it would be hard to write 
manually.

Regards
Joakim