[MPlayer-dev-eng] [PATCH] add optional device with dvd://

[compn]

On Sat, 5 Jul 2008 13:25:59 +0200, Diego Biurrun wrote:
>On Thu, Jul 03, 2008 at 02:35:56PM +0200, Nico Sabbi wrote:
>> On Thursday 03 July 2008 12:47:49 Mathieu SCHROETER wrote:
>> > Mathieu SCHROETER a écrit :
>> >  >+  if(!p->device)
>> >  >+    dvd_device_current = strdup(dvd_device ? dvd_device :
>> >
>> > DEFAULT_DVD_DEVICE);
>> >
>> > Sorry previous patch is wrong because a leak exists on
>> > dvd_device_current. Now strdup() is only used on dvd_device
>> > (if necessary)...
>> 
>> thanks, I'll review it tonight
>
>So you reviewed the patch and committed, but why FOR FUCK'S SAKE did you
>have to leave out the documentation part?
>
>How often do I have to repeat this?  Never ever split off the
>documentation part from a patch.  It causes extra work for *you* as well
>as for everybody else.

more often its just a simple case of forgetting to add the docs file when committing.

patch -p0 <file.patch
svn diff stream_dvd.c
svn commit stream_dvd.c
write commit message

-compn