[MPlayer-dev-eng] [PATCH] add optional device with dvd://

[Diego Biurrun]

On Sat, Jul 05, 2008 at 02:57:49PM +0200, Nico Sabbi wrote:
> Il giorno sab, 05/07/2008 alle 13.25 +0200, Diego Biurrun ha scritto:
> > On Thu, Jul 03, 2008 at 02:35:56PM +0200, Nico Sabbi wrote:
> > > On Thursday 03 July 2008 12:47:49 Mathieu SCHROETER wrote:
> > > > Mathieu SCHROETER a écrit :
> > > >  >+  if(!p->device)
> > > >  >+    dvd_device_current = strdup(dvd_device ? dvd_device :
> > > >
> > > > DEFAULT_DVD_DEVICE);
> > > >
> > > > Sorry previous patch is wrong because a leak exists on
> > > > dvd_device_current. Now strdup() is only used on dvd_device
> > > > (if necessary)...
> > > 
> > > thanks, I'll review it tonight
> > 
> > How often do I have to repeat this?  Never ever split off the
> > documentation part from a patch.  It causes extra work for *you* as well
> > as for everybody else.
> 
> 
> btw, I committed only the english part because, although
> I'm using an utf8 system, the french part appeared corrupt.

That's because the manual pages are not UTF-8 unfortunately.  There are
no (widely available) roff implementations that support UTF-8.  Yes,
it's a crying shame...

> Someone commit the french part if it's ok, please

Done.

Note that this is much less of a problem since translators will take
care of it eventually, albeit with a bit of duplicated work.  If you
skip the English master, chances are that it will be forgotten and not
documented for many years, if at all.

Diego