[MPlayer-dev-eng] [PATCH] add optional device with dvd://
nicola.sabbi at poste.it
Sat Jul 5 14:57:49 CEST 2008
Il giorno sab, 05/07/2008 alle 13.25 +0200, Diego Biurrun ha scritto:
> On Thu, Jul 03, 2008 at 02:35:56PM +0200, Nico Sabbi wrote:
> > On Thursday 03 July 2008 12:47:49 Mathieu SCHROETER wrote:
> > > Mathieu SCHROETER a écrit :
> > > >+ if(!p->device)
> > > >+ dvd_device_current = strdup(dvd_device ? dvd_device :
> > >
> > > DEFAULT_DVD_DEVICE);
> > >
> > > Sorry previous patch is wrong because a leak exists on
> > > dvd_device_current. Now strdup() is only used on dvd_device
> > > (if necessary)...
> > thanks, I'll review it tonight
> So you reviewed the patch and committed, but why FOR FUCK'S SAKE did you
> have to leave out the documentation part?
> How often do I have to repeat this? Never ever split off the
> documentation part from a patch. It causes extra work for *you* as well
> as for everybody else.
> Oh, and this violates II.8 and II.11 of the policy, in case you care.
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
btw, I committed only the english part because, although
I'm using an utf8 system, the french part appeared corrupt.
Someone commit the french part if it's ok, please
More information about the MPlayer-dev-eng