[MPlayer-dev-eng] [PATCH] add optional device with dvd://

Mathieu SCHROETER mathieu.schroeter at gamesover.ch
Tue Jul 8 14:39:15 CEST 2008

elupus a écrit :
> Mathieu SCHROETER <mathieu.schroeter <at> gamesover.ch> writes:
>> Hello,
>> this patch will add an optional argument for stream_dvd to handle
>> a dvd_device with the MRL..  like cdda, vcd, etc, ...
>> Very useful when MPlayer is used with "-slave -idle" modes..
>> dvd://[title|[start_title]-end_title][/device]
>> An optional device can be already used with dvdnav://, but that is
>> not specified in the manpage. This patch will fix the manpage too..
>> I'm not sure if that is the best way for a thing.. when dvd_close()
>> is called, there is no way in order to read the optional argument.
>> Then I've added a global variable with the current device used.
>> And if the argument is NULL, dvd_device is used as before..
>> Regards,
>> Attachment (stream_dvd-optional_device.patch): text/x-patch, 3697 bytes
> This may be abit late, but i find this counter intuative. 
> Something like would have made more sence imho.
> dvd://[device/][title|[start_title]-end_title]

It needs a lot of changes.. and for consistency, changes
for cdd[ab], vcd too.

Look at the end of ./parser-mpcmd.c and I think you will
understand why (at least for dvd://)..

"/device" at the end is the simplest way IMO.


More information about the MPlayer-dev-eng mailing list