[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Reimar Döffinger]

Hello,
On Sat, Jan 26, 2008 at 11:12:16AM +0100, Benjamin Zores wrote:
> Rich Felker a écrit :
> > On Fri, Jan 25, 2008 at 12:55:58PM +0100, Benjamin Zores wrote:
> >>> Indentation is only 2 elsewhere.
> >> This is a point I wanted to talk about in a dedicated thread but as
> >> you're starting with it.
> >> We don't have any coding rules. Some files use a 2 spaces indent,
> >> others a 4, some uses tabs, and some files mixes everything.
> >> Would it be possible for us to agree on a coding standard (say ffmpeg
> >> one or whatever), apply the "indent" command with the appropriate
> >> options on all C and H files (maybe that can be done in post-commit
> >> treatments as well) and we're done with this once for all ?
> > 
> > STRONGLY OPPOSED.
> > 
> > This has nothing to do with improving the quality of the code.
> > Claiming it does is nonsense. Please do not reignite this age-old
> > flame topic!!!
> 
> I totally agree with you regarding quality of code: it won't improve 
> anything at all, that's for sure.

Actually that is not completely true. It does increase readability,
which for code that is already reasonably clean and actually gets changed
once in a while will lead to better code.
Just reindenting some horribly messy code will of course not help it.
I was specifically thinking if we can get some kind of list of maybe at
most two styles that we consider "preferred" and that all actively
maintained files will sooner or later switch to.