[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Benjamin Zores]

Rich Felker a écrit :
> On Fri, Jan 25, 2008 at 12:55:58PM +0100, Benjamin Zores wrote:
>>> Indentation is only 2 elsewhere.
>> This is a point I wanted to talk about in a dedicated thread but as
>> you're starting with it.
>> We don't have any coding rules. Some files use a 2 spaces indent,
>> others a 4, some uses tabs, and some files mixes everything.
>> Would it be possible for us to agree on a coding standard (say ffmpeg
>> one or whatever), apply the "indent" command with the appropriate
>> options on all C and H files (maybe that can be done in post-commit
>> treatments as well) and we're done with this once for all ?
> 
> STRONGLY OPPOSED.
> 
> This has nothing to do with improving the quality of the code.
> Claiming it does is nonsense. Please do not reignite this age-old
> flame topic!!!

I totally agree with you regarding quality of code: it won't improve 
anything at all, that's for sure.

However, it's really a pain having to patch files right now and check 
every single line to see if the ones before/after are actually using 
2/4/8 spaces or tabs. If you don't want any coding rules, that's fine 
but then we shouldn't care at all about indentation, if one uses 8 
spaces instead of tabs somewhere, then ... whatever ... it won't change 
quality of code anyhow, as you said.

Ben