[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Reimar Döffinger]

Hello,
On Sat, Jan 26, 2008 at 10:08:27AM +0100, Nico Sabbi wrote:
> Il Saturday 26 January 2008 02:39:51 Rich Felker ha scritto:
> > On Fri, Jan 25, 2008 at 12:55:58PM +0100, Benjamin Zores wrote:
> > > > Indentation is only 2 elsewhere.
> > >
> > > This is a point I wanted to talk about in a dedicated thread but
> > > as you're starting with it.
> > > We don't have any coding rules. Some files use a 2 spaces indent,
> > > others a 4, some uses tabs, and some files mixes everything.
> > > Would it be possible for us to agree on a coding standard (say
> > > ffmpeg one or whatever), apply the "indent" command with the
> > > appropriate options on all C and H files (maybe that can be done
> > > in post-commit treatments as well) and we're done with this once
> > > for all ?
> >
> > STRONGLY OPPOSED.
> >
> > This has nothing to do with improving the quality of the code.
> > Claiming it does is nonsense. Please do not reignite this age-old
> > flame topic!!!
> >
> > Rich
> 
> indeed the rediscussion of this topic is one of the few certainties
> of life ...

Well, I sure think that at least new code being visually consistent
would be worth something (please ignore the part about using indent
though, it messes up far too often anyway).