[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Diego Biurrun]

On Fri, Jan 25, 2008 at 08:39:51PM -0500, Rich Felker wrote:
> On Fri, Jan 25, 2008 at 12:55:58PM +0100, Benjamin Zores wrote:
> > > Indentation is only 2 elsewhere.
> > 
> > This is a point I wanted to talk about in a dedicated thread but as
> > you're starting with it.
> > We don't have any coding rules. Some files use a 2 spaces indent,
> > others a 4, some uses tabs, and some files mixes everything.
> > Would it be possible for us to agree on a coding standard (say ffmpeg
> > one or whatever), apply the "indent" command with the appropriate
> > options on all C and H files (maybe that can be done in post-commit
> > treatments as well) and we're done with this once for all ?
> 
> STRONGLY OPPOSED.
> 
> This has nothing to do with improving the quality of the code.
> Claiming it does is nonsense. Please do not reignite this age-old
> flame topic!!!

You just jumped at a keyword (indent) without taking any sort of context
into account, way to go ...

Diego