[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Nico Sabbi]

Il Friday 25 January 2008 00:07:06 Benjamin Zores ha scritto:
> Nico Sabbi a écrit :

> >
> > the dvdnav changes may go in after some changes, but since I know
> > next to nothing about the decoders and osd interface I'm not
> > really qualified to judicate the rest.
>
> Hum, there's nothing related to OSD in this patch.
> It's just plain still frames support.
> Can you tell me about the changes you're thinking about ?

in a different incarnation of this patch that I reviewed at the time
there were a lot of changes to the OSD, now I see you removed them

>
> > Also, all the changes to the _decode_() functions look very messy
> > to me
>
> Yeah, same for me.
> But again, this is a rip of minimalistic patch that provides still
> frames support.
> Consider it as a base on which we can work on.
> Ideas and comments are welcomed from people more friendly with
> decoding stuff.
>
> Ben

agree, and thanks for resurrecting and splitting this patch!