[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

Benjamin Zores ben at geexbox.org
Fri Jan 25 00:07:06 CET 2008


Nico Sabbi a écrit :
> Il Thursday 24 January 2008 23:29:28 Benjamin Zores ha scritto:
>> Hi,
>>
>> Attached patch provides still frames support for dvdnav.
>> It has been ripped from Otvos Attila dvdnav monster patchset to
>> include only the required changes for still frames support.
>>
>> While being stripped down it's still huge but shouldn't hurt
>> non-dvdnav streams (at least shouldn't change how they play back).
>>
>> Please comment which part must be rewritten (or enhanced another
>> way) and I'll do so until it reaches a mergeable state.
>> FYI, I've already rewrote parts of original patch.
>>
>> Ben
> 
> the dvdnav changes may go in after some changes, but since I know next
> to nothing about the decoders and osd interface I'm not really 
> qualified to judicate the rest.

Hum, there's nothing related to OSD in this patch.
It's just plain still frames support.
Can you tell me about the changes you're thinking about ?

> Also, all the changes to the _decode_() functions look very messy to
> me

Yeah, same for me.
But again, this is a rip of minimalistic patch that provides still 
frames support.
Consider it as a base on which we can work on.
Ideas and comments are welcomed from people more friendly with decoding 
stuff.

Ben



More information about the MPlayer-dev-eng mailing list