[MPlayer-dev-eng] [PATCH] color SPU with ass (EOSD)

[Reimar Döffinger]

Hello,
On Tue, Dec 11, 2007 at 11:07:54PM +0300, Evgeniy Stepanov wrote:
> On Tuesday 11 December 2007 22:51:43 Reimar Döffinger wrote:
> > On Tue, Dec 11, 2007 at 08:24:56PM +0300, Evgeniy Stepanov wrote:
> > > On Tuesday 04 December 2007 16:40:40 Ötvös Attila wrote:
> > > > Ezzel a dátummal: Tuesday 04 December 2007 14.25.09 Ulion ezt írta:
> > > > > That's all I can do. You may contact Evgeniy Stepanov to see whether
> > > > > he can help you to commit these patches.
> > >
> > > I'm not sure what to do with these patches. The generators part has some
> > > minor problems. For instance, vo_gl does not work correctly when there is
> > > more than non-empty image list for the same frame. It won't segfault
> > > either, but only one of the lists will be displayed. On the other hand,
> > > this never happens with the current code, because, obviously, any
> > > subtitle track is either SSA/ASS, or VobSub, not both. It will happen if,
> > > for example, OSD is rendered with libass at some point in future.
> >
> > What do you mean to say? Do you think this is a problem with vo_gl code
> > or with these patches?
> > I think supporting multiple image lists would be very difficult because
> > of the imgs->changed == 0 case.
> 
> Why ? Multiple lists are almost the same as one list, but with slightly more 
> information: each list has a separate 'changed' flag. For an easy solution 
> one can simply use min() of them.
> 
> It should be easy to do if all lists were passed to vo at once, isn't it ?

No, not unless you make some additional assumptions. What does it help
you if you know that e.g. the "first" list wasn't changed if you have no
idea which list that was in the last call? That first list might have
been the 10th in the last call to the function or it could have been the
first one...
Or IOW: you'd need unique way to identify each list in addition.

Greetings,
Reimar Döffinger