[MPlayer-dev-eng] [PATCH] allow changing osd font scale independently from sub font one

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jan 6 21:05:53 CET 2008


Hello,
On Wed, Dec 26, 2007 at 04:16:00PM +0800, Ulion wrote:
> 2007/12/26, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Wed, Dec 26, 2007 at 01:53:49AM +0100, Guillaume LECERF wrote:
> > [...]
> > > I suggest the attached patch which loads the font only if vo_font is
> > > null, and not depending on force_load_font because config() won't be
> > > called after force_load_font has been changed.
> >
> > Will most likely break the OSD with -vo gl.
> 
> I don't have vo gl, how? If only vo_update_osd get called, freetype
> font will be loaded. Here in libmenu it's just incase when
> -menu-startup set while freetype font not load it will crash in
> libmenu so here load vo_font. Can you explain it detaily?

vo_gl.c has the following code in resize():
>    // adjust font size to display size
>    force_load_font = 1;

This is so that when scaling the window the OSD font will be scaled as
well (otherwise the OSD will remain tiny when e.g. going to fullscreen).
Probably the same can be achieved after your patch by setting vo_font to
NULL here or some other solution (or maybe I even misunderstood the
patch, I did not read too closely, nor did I test yet).
Btw. you should be able to use -vo gl via software emulation of OpenGL
e.g. via the Mesa libraries. It's too slow to actually watch videos but
should be good enough for testing...

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list