[MPlayer-dev-eng] [PATCH] Move SSA/ASS subtitles handling out?of mkv demuxer

[Reimar Döffinger]

Hello,
On Sun, Dec 30, 2007 at 06:35:59PM +0300, Evgeniy Stepanov wrote:
> @@ -110,8 +112,8 @@
>  sh_audio_t* new_sh_audio_aid(demuxer_t *demuxer,int id,int aid);
>  #define new_sh_video(d, i) new_sh_video_vid(d, i, i)
>  sh_video_t* new_sh_video_vid(demuxer_t *demuxer,int id,int vid);
> -#define new_sh_sub(d, i) new_sh_sub_sid(d, i, i)
> -sh_sub_t *new_sh_sub_sid(demuxer_t *demuxer, int id, int sid);
> +#define new_sh_sub(d, i) new_sh_sub_sid(d, i, i, '\0')
> +sh_sub_t *new_sh_sub_sid(demuxer_t *demuxer, int id, int sid, char type);

I don't like this, we don't pass codec ID/fourcc to
new_sh_video/new_sh_audio either, these functions do almost the same
thing and they should work almost the same way (though I admit that
having ass_new_track() in each demuxer is rather ugly as well... maybe
you can thing of an even better idea? ;-)
Maybe check for !ass_track at some place where it is used and allocate it
dynamically? Should reduce the memory usage for files with many ass
tracks, too...

Greetings,
Reimar Döffinger