[MPlayer-dev-eng] libvo changes

[Diego Biurrun]

On Sat, Apr 05, 2008 at 08:48:31PM +0300, Uoti Urpala wrote:
> On Sat, 2008-04-05 at 19:19 +0200, Reimar Döffinger wrote:
> > On Sat, Apr 05, 2008 at 07:55:14PM +0300, Uoti Urpala wrote:
> > > video_out.c: Clean up some code
> > 
> > That's a bad commit message. I _think_ those are only cosmetics, if so
> > please say so explicitly.
> 
> IIRC that commit changes code formatting and renames a variable. IMO
> "clean up" tells clearly enough that the commit should not contain
> functionality changes. Do you want a clearer distinction between "does
> not change functionality" and "unlikely to change compiler output at
> all"? I'm not sure when you'd care about that when reading the commit
> log.

I dislike "clean up" as commit message as well.  It's far from specific
(enough) to be really useful.

Diego