[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[The Wanderer]

Ulion wrote:

>> the idea was to keep the patch as small as possible and w/out much
>> overhead.
>> 
>> currently there are some cosmetics like
>> 
>> -            // read out all pending events
>> -            while (result == kIOReturnSuccess)
>> -                result = (*queue)->getNextEvent(queue, &event,
>> zeroTime, 0);
>> +            // Read out all pending events.
>> +            while (ret != MP_INPUT_NOTHING)
>> +                ret = mp_input_ar_read_raw(&eventTime);
>> 
>> That you may avoid/commit separately.
> 
> This place you pointed out, is necessary for this patch. First line
> is comment fix, that should be fixed for each patch Diego reviewed.

Comment fixes (at least ones which do not change the effective meaning
of the comment) are still cosmetic, and I believe there is precedent for
them being applied separately.

> Second and third lines is modified caused by the original read event
> code is all moved into mp_input_ar_read_raw, we need call that method
> to read out all events here.

I think this one is valid, though.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.