[MPlayer-dev-eng] [PATCH] Apple Remote support double click

Ulion ulion2002 at gmail.com
Fri Sep 28 02:53:13 CEST 2007


> >
> >>>> b- remove the debug clutter
> >>> You mean the define TEST part or the mp_msg debug output?
> >> yes
> >>
> >
> > OK, I removed the define TEST part. Did you also suggest remove mp_msg
> > debug part?
>
> the idea was to keep the patch as small as possible and w/out much overhead.
>
> currently there are some cosmetics like
>
> -            // read out all pending events
> -            while (result == kIOReturnSuccess)
> -                result = (*queue)->getNextEvent(queue, &event,
> zeroTime, 0);
> +            // Read out all pending events.
> +            while (ret != MP_INPUT_NOTHING)
> +                ret = mp_input_ar_read_raw(&eventTime);
>
> That you may avoid/commit separately.

This place you pointed out, is necessary for this patch. First line is
comment fix, that should be fixed for each patch Diego reviewed.
Second and third lines is modified caused by the original read event
code is all moved into mp_input_ar_read_raw, we need call that method
to read out all events here.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list