[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[Luca Barbato]

Ulion wrote:
> 2007/9/27, Luca Barbato <lu_zero at gentoo.org>:
>> Ulion wrote:
>>> You mean apple remote? or doubleclick?
>> I meant doubleclick.
>>
> 
> it seems that lirc does not support doubleclick.
> 
>>>> comment on the patch:
>>>>
>>>> a- avoid LOOOONG lines 79 cols at most.
>>> I re-checked the patch, most lines longer than 80 columns is msg
>>> print, which I have no idea how to break the print message without add
>>> spaces into the print result, any idea?
>> "this is"
>> " a string"
>> " split many times"
> 
> Thanks, the too long line problem is now fixed.
> 
> 
>>>> b- remove the debug clutter
>>> You mean the define TEST part or the mp_msg debug output?
>> yes
>>
> 
> OK, I removed the define TEST part. Did you also suggest remove mp_msg
> debug part?

the idea was to keep the patch as small as possible and w/out much overhead.

currently there are some cosmetics like

-            // read out all pending events
-            while (result == kIOReturnSuccess)
-                result = (*queue)->getNextEvent(queue, &event,
zeroTime, 0);
+            // Read out all pending events.
+            while (ret != MP_INPUT_NOTHING)
+                ret = mp_input_ar_read_raw(&eventTime);

That you may avoid/commit separately.

lu


-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero