[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[Ulion]

2007/9/28, The Wanderer <inverseparadox at comcast.net>:
> Ulion wrote:
>
> >> the idea was to keep the patch as small as possible and w/out much
> >> overhead.
> >>
> >> currently there are some cosmetics like
> >>
> >> -            // read out all pending events
> >> -            while (result == kIOReturnSuccess)
> >> -                result = (*queue)->getNextEvent(queue, &event,
> >> zeroTime, 0);
> >> +            // Read out all pending events.
> >> +            while (ret != MP_INPUT_NOTHING)
> >> +                ret = mp_input_ar_read_raw(&eventTime);
> >>
> >> That you may avoid/commit separately.
> >
> > This place you pointed out, is necessary for this patch. First line
> > is comment fix, that should be fixed for each patch Diego reviewed.
>
> Comment fixes (at least ones which do not change the effective meaning
> of the comment) are still cosmetic, and I believe there is precedent for
> them being applied separately.

Since you insist, I give a patch without this comment fix.

>
> > Second and third lines is modified caused by the original read event
> > code is all moved into mp_input_ar_read_raw, we need call that method
> > to read out all events here.
>
> I think this one is valid, though.

The function mp_input_ar_read_raw hide the detail of reading ar events
underground, and just give out the events it reads. In function
mp_input_ar_read, just call mp_input_ar_read_raw to read events, need
not known any detail of how to read raw events.


-- 
Ulion
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: apple_remote_double_click4.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070928/ca5fadbb/attachment.txt>