[MPlayer-dev-eng] [PATCH] Refreshed OS/2 Patches

[Diego Biurrun]

On Sun, Jul 29, 2007 at 11:00:52PM +0900, KO Myung-Hun wrote:
> 
> Attila Kinali wrote:
> > On Tue, 17 Jul 2007 22:41:00 +0900
> > KO Myung-Hun <komh at chollian.net> wrote:
> >   
> > And finally you should split the kva and dart patches
> > (rule of thumb: things that do not depend on each other should
> > be in different patches).
> 
> I have questions.
> 
> configure script has patches for both kva and dart. In this case, should 
> I split configure script into kva and dart, respectively ?
> 
> And in the case of common parts, what should I do ? That is, configure 
> script has common code for both kva and dart. Should I include those 
> codes to both kva and dart pathces ?

Patches should be independent.  If I were to apply your vo driver patch,
it would not work because the build system part is missing.

So yes, you should not split your patch by file, but by logical entity.
This means that the vo/ao driver patches should come with separate
changes to configure.

There is no common kva and dart code in your configure patch.

> > Other than that, someone with an understanding of libao
> > and libvo should check those patches.
> 
> Hmm... Who are they ?
> 
> Anyway it's very difficult to merge patches to official repository.

Try FFmpeg :)  Or libdvdcss, libdvdread, libmpeg2 ...

Diego