[MPlayer-dev-eng] [PATCH] Refreshed OS/2 Patches

[KO Myung-Hun]

Hi/2.

Attila Kinali wrote:
> On Tue, 17 Jul 2007 22:41:00 +0900
> KO Myung-Hun <komh at chollian.net> wrote:
>
>   
>> +static uint8_t *m_audioBuf = NULL;
>> +static volatile int m_nBufSize = 0;
>> +static volatile int m_nBufLen = 0;
>> +static volatile int m_iBufPos = 0;
>>     
>
> Why the heck are these variables volatile?
>
>   

What's wrong with them ?

> You should definitly use standard c types instead of ULONG and
> the like. 

I don't understand you. It's specific codes to OS/2. It is natural that 
the specific data types to OS/2 are used, isn't it ? If not, can you 
explain the case of win32 implementation and others ?

> You should generally add more comments in the code
> so that even someone w/o OS/2 programming knowledge can understand
> it. 

Ok. I'll try to add more comments.

> And finally you should split the kva and dart patches
> (rule of thumb: things that do not depend on each other should
> be in different patches).
>
>   

I have questions.

configure script has patches for both kva and dart. In this case, should 
I split configure script into kva and dart, respectively ?

And in the case of common parts, what should I do ? That is, configure 
script has common code for both kva and dart. Should I include those 
codes to both kva and dart pathces ?

> Other than that, someone with an understanding of libao
> and libvo should check those patches.
>   

Hmm... Who are they ?

Anyway it's very difficult to merge patches to official repository.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.2
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr