[MPlayer-dev-eng] [PATCH] Switch libavutil macros instead of defining our own

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Feb 26 11:11:15 CET 2007

On Mon, Feb 26, 2007 at 10:07:05AM +0100, Diego Biurrun wrote:
> On Sat, Feb 24, 2007 at 11:25:00PM +0100, Michael Niedermayer wrote:
> > i think it not only looks better but it is more readable but thats surely
> > just MHO
> Michael's HO is MHO as well, I am in favor of this.  At least for me,
> this helps readability a lot..

For now, keeping the status quo and Roberto's opinion win, since you two
seem much less likely to stumble over that code ;-).
I also have the feeling that there are ways to increase the code's
readability that are more effective, like using calloc instead of malloc
and then setting every single struct member to 0 by hand or using some
kind of strndup (since it's not only strings, memdup would be a more
appropriate name I guess) function instead of duplicating the code at least 7

Reimar Döffinger

More information about the MPlayer-dev-eng mailing list