[MPlayer-dev-eng] [PATCH] Switch libavutil macros instead of defining our own

[Diego Biurrun]

On Sat, Feb 24, 2007 at 11:25:00PM +0100, Michael Niedermayer wrote:
> 
> On Sat, Feb 24, 2007 at 08:58:38PM +0100, Roberto Togni wrote:
> > On Sat, 24 Feb 2007 19:23:05 +0100
> > Michael Niedermayer <michaelni at gmx.at> wrote:
> > 
> > [...]
> > > > @@ -78,40 +73,40 @@
> > > >  
> > > >    if (!fileheader) return;
> > > > -  fileheader->object_id=BE_32(&fileheader->object_id);
> > > > -  fileheader->size=BE_32(&fileheader->size);
> > > > -  fileheader->object_version=BE_16(&fileheader->object_version);
> > > > -  fileheader->file_version=BE_32(&fileheader->file_version);
> > > > -  fileheader->num_headers=BE_32(&fileheader->num_headers);
> > > > +  fileheader->object_id=AV_RB32(&fileheader->object_id);
> > > > +  fileheader->size=AV_RB32(&fileheader->size);
> > > > +  fileheader->object_version=AV_RB16(&fileheader->object_version);
> > > > +  fileheader->file_version=AV_RB32(&fileheader->file_version);
> > > > +  fileheader->num_headers=AV_RB32(&fileheader->num_headers);
> > > 
> > > as you already change it what about also vertically aligning it :)
> > > 
> > 
> > Please don't. It won't look any better 
> 
> fileheader->object_id=AV_RB32(&fileheader->object_id);
> fileheader->size=AV_RB32(&fileheader->size);
> fileheader->object_version=AV_RB16(&fileheader->object_version);
> fileheader->file_version=AV_RB32(&fileheader->file_version);
> fileheader->num_headers=AV_RB32(&fileheader->num_headers);
> 
> vs.
> 
> fileheader->object_id     =AV_RB32(&fileheader->object_id);
> fileheader->size          =AV_RB32(&fileheader->size);
> fileheader->object_version=AV_RB16(&fileheader->object_version);
> fileheader->file_version  =AV_RB32(&fileheader->file_version);
> fileheader->num_headers   =AV_RB32(&fileheader->num_headers);
> 
> i think it not only looks better but it is more readable but thats surely
> just MHO

Michael's HO is MHO as well, I am in favor of this.  At least for me,
this helps readability a lot..

Diego