[MPlayer-dev-eng] [RFC] subtitle code in mencoder
Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Feb 16 19:17:58 CET 2007
On Fri, Feb 16, 2007 at 07:03:05PM +0200, Uoti Urpala wrote:
> On Fri, 2007-02-16 at 17:06 +0100, Reimar Döffinger wrote:
> > Updated version, it now isn't included into mplayer.c but instead passes
> > two extra parameters to update_subtitles()
> > I will apply very, very soon.
> I'm not really against but don't like the spread of the subtitle code
> over so many files.
That some of the parts are in libvo although they are not really related
to vo does not make it better.
> I prefer the former, as mplayer.c should be split up anyway
> and functionality moved to smaller files - splitting some code to one
> mpcommon.c would still leave the files too big.
Well, that's at least somewhat orthogonal. I am mostly thinking about
removing code duplication first of all, because it makes any
architectural changes sooo painful.
Whatever we do, there will still be _loads_ of cleanup tasks left, I
just want to get started somewhere, without caring if there are better
solutions as long as we agree it is an improvement. We'll never get
anywhere if we way for someone to bring along the perfect solution IMO
More information about the MPlayer-dev-eng