[MPlayer-dev-eng] [RFC] subtitle code in mencoder
uoti.urpala at pp1.inet.fi
Fri Feb 16 18:03:05 CET 2007
On Fri, 2007-02-16 at 17:06 +0100, Reimar Döffinger wrote:
> Updated version, it now isn't included into mplayer.c but instead passes
> two extra parameters to update_subtitles()
> I will apply very, very soon.
I'm not really against but don't like the spread of the subtitle code
over so many files. There are already 2 shared subtitle-specific files
at the top level. If subreader.c is mainly for reading various formats
from external files then IMO either this functionality should be in
find_sub.c or the contents of find_sub.c should later be moved to
mpcommon.c. I prefer the former, as mplayer.c should be split up anyway
and functionality moved to smaller files - splitting some code to one
mpcommon.c would still leave the files too big.
More information about the MPlayer-dev-eng