[MPlayer-dev-eng] [RFC] subtitle code in mencoder

Uoti Urpala uoti.urpala at pp1.inet.fi
Fri Feb 16 19:25:57 CET 2007

On Fri, 2007-02-16 at 19:17 +0100, Reimar Döffinger wrote:
> On Fri, Feb 16, 2007 at 07:03:05PM +0200, Uoti Urpala wrote:
> > I prefer the former, as mplayer.c should be split up anyway
> > and functionality moved to smaller files - splitting some code to one
> > mpcommon.c would still leave the files too big.
> Well, that's at least somewhat orthogonal. I am mostly thinking about
> removing code duplication first of all, because it makes any
> architectural changes sooo painful.
> Whatever we do, there will still be _loads_ of cleanup tasks left, I
> just want to get started somewhere, without caring if there are better
> solutions as long as we agree it is an improvement. We'll never get
> anywhere if we way for someone to bring along the perfect solution IMO
> :-)

Moving other stuff is orthogonal of course, but moving the subtitle code
first to mpcommon.c and then somewhere else isn't really. Especially if
it's done before other stuff is moved to mpcommon.c so that it then
becomes empty :)

More information about the MPlayer-dev-eng mailing list