[MPlayer-dev-eng] Re: [PATCH] Make all subtitles availiable

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Feb 15 14:53:56 CET 2007

On Thu, Feb 15, 2007 at 02:17:21PM +0100, Lehel Bernadt wrote:
> I've tried that approach, and "might behave a bit weird" = "gets broken" in 
> this case. I hadn't investigated why, I guess it would need to be checked in 
> the sub switching code whether a sub id corresponds to a real sub or is 
> a "hole".

Huh? It just has some extra subtitles that have no language assigned and
probably won't display anything. Not beautiful, but really who cares?

> The other problem with your idea is, that returning with the number of the 
> physical subpic streams (i.e. all of them) instead of the number of the 
> logical subs (as listed in the DVD title) breaks the sub identification, 
> since that info is read from the DVD title, and not from the MPEG2 stream.
> That's why I think that my patch is OK as it is.

Huh??? The number in the DVD title description is the id in the MPEG-PS
stream. Actually the thing that currently gets passed around is some
made-up number that does not really have anything to do with what is
stored in the DVD title description AFAICT.
A strong indication for this interpretation is also the fact that WinDVD
allows you to select subtitles that are not marked as present - meaning
that WinDVD completely ignores this flag, whereas in MPlayer it even
changes the subtitle numbering.

Reimar Döffinger

More information about the MPlayer-dev-eng mailing list