[MPlayer-dev-eng] Re: [PATCH] Make all subtitles availiable

[Lehel Bernadt]

On Thursday 15 February 2007 14:53, Reimar Döffinger wrote:
> Hello,
>
> On Thu, Feb 15, 2007 at 02:17:21PM +0100, Lehel Bernadt wrote:
> > I've tried that approach, and "might behave a bit weird" = "gets broken"
> > in this case. I hadn't investigated why, I guess it would need to be
> > checked in the sub switching code whether a sub id corresponds to a real
> > sub or is a "hole".
>
> Huh? It just has some extra subtitles that have no language assigned and
> probably won't display anything. Not beautiful, but really who cares?

I just wrote that when I tried it out, it broke the subtitle switching. That's 
all.

>
> > The other problem with your idea is, that returning with the number of
> > the physical subpic streams (i.e. all of them) instead of the number of
> > the logical subs (as listed in the DVD title) breaks the sub
> > identification, since that info is read from the DVD title, and not from
> > the MPEG2 stream. That's why I think that my patch is OK as it is.
>
> Huh??? The number in the DVD title description is the id in the MPEG-PS
> stream. 

The number in the DVD title description is _not_ the stream id, they are two 
different things. See the attached screenshots.

> Actually the thing that currently gets passed around is some 
> made-up number that does not really have anything to do with what is
> stored in the DVD title description AFAICT.

It's not "made up", it's actually what is stored in the DVD title description.

> A strong indication for this interpretation is also the fact that WinDVD
> allows you to select subtitles that are not marked as present - meaning
> that WinDVD completely ignores this flag, whereas in MPlayer it even
> changes the subtitle numbering.

There are no interpretations, just one DVD spec. Please try out a DVD editing 
program if you need to clear up things for yourself.

If you want mplayer to be able to select all the spu streams in the MPEG-PS, 
it's possible, but it needs a rethink/rewrite of the subtitle handling logic.

If you disagree with this statement, I really don't want to argue, I just 
wanted to help with my patch. I tried out quite a few possible variations 
until I arrived at what I got, which I think is the most simple working 
solution. Without wanting to offend you, suggesting unworkable fixes with 
argumentation using  "probably", "might", "AFAICT" is not very professional 
after this.

Best wishes,
Lehel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvd_mapping.jpg
Type: image/jpeg
Size: 34005 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070215/9cdcfe15/attachment.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvd_title.jpg
Type: image/jpeg
Size: 44406 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070215/9cdcfe15/attachment-0001.jpg>