[MPlayer-dev-eng] Re: [PATCH] AM_MEDIA_TYPE related utils

[Alan Nisota]

Vladimir Voroshilov writes:
> 
> 2007/2/11, Alan Nisota <alannisota <at> gmail.com>:
> > Vladimir Voroshilov <voroshil <at> gmail.com> writes:
> >
> > I am concerned about this patch.  Did you use mtype.cpp from the DirectX 
SDK as
> > a basis?
> 1. Yes. it is based on mtype.cpp and this will be real trouble. I've
> wrtitten it some time ago. I don't know how to implement this things
> without having troubles with license issues.Thus i'll be glad to see
> your implementation of the same routines.

I don't think I should try to write it either now that I've looked at the 
DirectXSDK source.  However, I would recommend taking the wine implementation 
here:
http://source.winehq.org/source/dlls/quartz/enummedia.c

and using that as the starting point.  The Wine guys take copyright very 
seriously, so I would expect their implementation to be clean.  It isn't all 
that different from yours, so should be easy to patch into shape.  Their 
license is compatible with the GPL of course.

> 2. if you don't like util.c filename feel free to suggest any other.
> 
It depends on the purpose.  If you want it to be a catch-all for static win32 
functions, you could call it winstaticlib.c.  Or you could name it as wine did 
if it only needs to include these baseclass functions.