[MPlayer-dev-eng] Re: [PATCH] AM_MEDIA_TYPE related utils
voroshil at gmail.com
Sun Feb 11 11:43:03 CET 2007
2007/2/11, Alan Nisota <alannisota at gmail.com>:
> Vladimir Voroshilov <voroshil <at> gmail.com> writes:
> I am concerned about this patch. Did you use mtype.cpp from the DirectX SDK as
> a basis? I have looked at that file (and as such would not feel comfortable
> writing these functions), and your implementation looks almost identical to
> Microsoft's. Maybe there is no other way to write the code in question (though
> if I had written the functions based purely off MSDN, I would not have written
> them as you did), but the structure of yours is very much the same as theirs,
> and I do not think Microsoft's DirectX SDK license is compatible with the GPL.
> I would advise caution in applying this patch.
1. Yes. it is based on mtype.cpp and this will be real trouble. I've
wrtitten it some time ago. I don't know how to implement this things
without having troubles with license issues.Thus i'll be glad to see
your implementation of the same routines.
2. if you don't like util.c filename feel free to suggest any other.
P.S. To get rid of thread duplication, i suggest to continue
discussion about AM_MEDIA_TYPE routines here.
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
More information about the MPlayer-dev-eng