[MPlayer-dev-eng] Re: [PATCH] AM_MEDIA_TYPE related utils

[Vladimir Voroshilov]

2007/2/11, Alan Nisota <alannisota at gmail.com>:
> I don't think I should try to write it either now that I've looked at the
> DirectXSDK source.  However, I would recommend taking the wine implementation
> here:
> http://source.winehq.org/source/dlls/quartz/enummedia.c
>
> and using that as the starting point.  The Wine guys take copyright very
> seriously, so I would expect their implementation to be clean.  It isn't all
> that different from yours, so should be easy to patch into shape.  Their
> license is compatible with the GPL of course.
Looked at their code.
Differences:
1. analyzing only pbFormat for decision about additional data. no real
sense for me.
2. absent checks for null argument. i'm not like this. Yes, you can
say that i'm paranoid :).
3. another usefull routine CompareMediaType.

Anyway i have prepared wine based version.
What will you say about it?
What will say another devs?

Well, please anybody also tell me what to do with licence notice. And
which license should we use? GPL or LGPL?
>
> > 2. if you don't like util.c filename feel free to suggest any other.
> >
> It depends on the purpose.  If you want it to be a catch-all for static win32
> functions, you could call it winstaticlib.c.  Or you could name it as wine did
> if it only needs to include these baseclass functions.
File renamed to mediatype.c
-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: media_type_utils2.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070211/c49b1584/attachment.txt>