[MPlayer-dev-eng] [PATCH] OSD menu freetype font loading bug fix.

[Ulion]

2007/12/26, Ulion <ulion2002 at gmail.com>:
> Hello,
>
> In libmenu/vf_menu.c's config(), it check flag force_load_font and
> load freetype font for vo_font and clear the flag. Here it missed
> loading freetype font for sub_font, it cleared the flag so the
> freetype font loading code in sub.c's vo_update_osd won't load
> sub_font if there's some bitmap font existed already loaded for
> vo_font and sub_font.
>
> This patch keep the freetype font loading code to prevent from crash
> with -menu-startup, but remove the flag clear code so other
> vo_update_osd will load the correct sub_font (and vo_font, there's
> memory, but that's another existed bug since once change the property
> sub_scale it will reload vo_font and sub_font and leak).
>
> Patch is short, so both pasted and attached.
>
> +++ libmenu/vf_menu.c   (working copy)
> @@ -205,7 +205,6 @@
>  #ifdef HAVE_FREETYPE
>    // here is the right place to get screen dimensions
>    if (force_load_font) {
> -    force_load_font = 0;
>      load_font_ft(width,height,&vo_font,font_name);
>    }

If there's no objeciton, I will apply it in 2 days.


-- 
Ulion