[MPlayer-dev-eng] [PATCH] OSD menu freetype font loading bug fix.

Ulion ulion2002 at gmail.com
Wed Dec 26 09:42:52 CET 2007


Hello,

In libmenu/vf_menu.c's config(), it check flag force_load_font and
load freetype font for vo_font and clear the flag. Here it missed
loading freetype font for sub_font, it cleared the flag so the
freetype font loading code in sub.c's vo_update_osd won't load
sub_font if there's some bitmap font existed already loaded for
vo_font and sub_font.

This patch keep the freetype font loading code to prevent from crash
with -menu-startup, but remove the flag clear code so other
vo_update_osd will load the correct sub_font (and vo_font, there's
memory, but that's another existed bug since once change the property
sub_scale it will reload vo_font and sub_font and leak).

Patch is short, so both pasted and attached.

+++ libmenu/vf_menu.c	(working copy)
@@ -205,7 +205,6 @@
 #ifdef HAVE_FREETYPE
   // here is the right place to get screen dimensions
   if (force_load_font) {
-    force_load_font = 0;
     load_font_ft(width,height,&vo_font,font_name);
   }


-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osdmenu_freetype_font_load_fix.diff
Type: text/x-diff
Size: 386 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071226/adcd68b1/attachment.diff>


More information about the MPlayer-dev-eng mailing list