[MPlayer-dev-eng] [PATCH] Apple Remote support

Ulion ulion2002 at gmail.com
Tue Aug 14 17:10:15 CEST 2007


2007/8/14, Diego Biurrun <diego at biurrun.de>:
>
> ...
> a button
> ...
> a button
> ...
> Always leave a space between parentheses and text in English.
please fix above three places for me.

>
>   Shorten cookie sequence by removing cookies with value 5 and 18
>   because 5 always follows 6 (on tiger), 18 always follows 19 (on leopard).
>
> > +        // as least 4 cookies to make up a valid sequence.
>
> aT least
>
> bettter:
>
> 4 cookies are needed to make up a valid sequence.
here I'm still prefer use the 'at least' prefix, this is what I mean here.

>
> Don't bother sending in a new patch, I'll make those changes and apply
> the patch in a moment.
>
> Diego
>
> P.S.: Your mails could be more readable if you left an empty line
> between your answer and the quoted text.
thank you.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list