[MPlayer-dev-eng] [PATCH] Apple Remote support

[Diego Biurrun]

On Tue, Aug 14, 2007 at 11:10:15PM +0800, Ulion wrote:
> 2007/8/14, Diego Biurrun <diego at biurrun.de>:
> >
> > ...
> > a button
> > ...
> > a button
> > ...
> > Always leave a space between parentheses and text in English.
> please fix above three places for me.
> 
> >
> >   Shorten cookie sequence by removing cookies with value 5 and 18
> >   because 5 always follows 6 (on tiger), 18 always follows 19 (on leopard).
> >
> > > +        // as least 4 cookies to make up a valid sequence.
> >
> > aT least
> >
> > bettter:
> >
> > 4 cookies are needed to make up a valid sequence.
> here I'm still prefer use the 'at least' prefix, this is what I mean here.

Your sentence is still lacking a proper verb because you are saying
"to make" instead of make.  You would either have to add something like
"are needed" or drop the "to".

Anyway, I fixed everything and committed the patch already.

> > Don't bother sending in a new patch, I'll make those changes and apply
> > the patch in a moment.
> >
> > Diego
> >
> > P.S.: Your mails could be more readable if you left an empty line
> > between your answer and the quoted text.
> thank you.

I would thank you if you could take the P.S. to heart :)

Diego