[MPlayer-dev-eng] [PATCH] Apple Remote support

[Diego Biurrun]

On Tue, Aug 14, 2007 at 09:14:23PM +0800, Ulion wrote:
> thanks, fixed patch is here

.. which disregards some of my comments ..

> --- input/ar.c	(revision 0)
> +++ input/ar.c	(revision 0)
> @@ -0,0 +1,470 @@
> +
> +// *down_state: button with this feature has a pressed event and

a button

> +// also a released event, we can trace the state of the button.
> +// button without this feature will only return one release event

a button

> +        // shorten cookie sequence by remove cookie value 5 and 18
> +        // because 5 always follows 6(on tiger), 18 follows 19(on leopard).

Always leave a space between parentheses and text in English.

  Shorten cookie sequence by removing cookies with value 5 and 18
  because 5 always follows 6 (on tiger), 18 always follows 19 (on leopard).

> +        // as least 4 cookies to make up a valid sequence.

aT least

bettter:

4 cookies are needed to make up a valid sequence.

Don't bother sending in a new patch, I'll make those changes and apply
the patch in a moment.

Diego

P.S.: Your mails could be more readable if you left an empty line
between your answer and the quoted text.